refactor(migrations): reduce branch complexity in executor and operation_generator#2231
Open
eujuliomorais wants to merge 1 commit into
Open
refactor(migrations): reduce branch complexity in executor and operation_generator#2231eujuliomorais wants to merge 1 commit into
eujuliomorais wants to merge 1 commit into
Conversation
waketzheng
reviewed
Jul 6, 2026
| # model_name is a model class | ||
| dep_key = (getattr(ref._meta, "app", ""), ref.__name__) | ||
| if dep_key in key_set and dep_key != key: | ||
| dep_key = OperationGenerator._dependency_key_for_field(field) |
Contributor
There was a problem hiding this comment.
How about change _sort_by_dependencies to be classmethod and use cls instead:
dep_key = cls._dependency_key_for_field(field)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
MigrationExecutor.migrateandOperationGenerator._sort_by_dependenciesto addressR0912(too-many-branches). Complex conditional structures were decomposed.Motivation and Context
High cyclomatic complexity was hindering code clarity and maintainability.
How Has This Been Tested?
Checklist: